PGN Parser #3
Merged
PGN Parser #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just saw someone else is also working on this as well |
8 tasks
There is still one test which fails. Will fix later
Still need a way to mock a function in dart.
Also removes streaming parser
|
Added benchmarks for the parser. After updating the packages use |
veloce
reviewed
Jan 11, 2023
lib/src/pgn.dart
Outdated
| bool operator ==(Object other) { | ||
| return other is Comment && | ||
| text == other.text && | ||
| // shapes == other.shapes && List == operator doesnt compare each component of list |
There was a problem hiding this comment.
why this code is commented out?
There was a problem hiding this comment.
This was used in testing to check if two comment objects were equal. But dart doesn't equate the list even if they have the same elements.
I don't think it's necessary.
veloce
reviewed
Jan 11, 2023
1. Renamed classes Node-> PgnNode, ChildNode->PgnChildNode, Game->PgnGame 2. Renamed parsePgn to parseMultiGamePgn 3. Added static methods makePgn and parsePgn to PgnGame 4. Moved makeVariant to its enum and renamed it to Variant.fromPgn 5. Move headers function to PgnGame 6. Removed walk function 7. Made some enums and classes private 8. Moved Outcome function to its class
1. Add makePgn benchmark 2. Renmane Comment and Evaluation Classes 3. Move function into classes 4. update tests
Also renamed functions and added comments
veloce
reviewed
Jan 12, 2023
| /// SAN representation of the move | ||
| final String san; | ||
|
|
||
| /// Starting comments of the node |
There was a problem hiding this comment.
what is a starting comment? it's hard to understand without context.
There was a problem hiding this comment.
I don't understand it either but chessops had it so I implemented that
There was a problem hiding this comment.
PGN moves can have a comment before and/or after the move.
1. Seperate PgnNodeData copyWith into 2 sepearate functions 2. Rename transformStack 3. Change parse function type and make PgnParse private 4. Use stringBuffer in makePgn instead of lists 5. Fix hashCode and == operator for PgnEvaluation
veloce
reviewed
Jan 13, 2023
veloce
reviewed
Jan 13, 2023
veloce
reviewed
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1